[8.18](backport #42714) [metricbeat] Refactor kubernetes bearer token authentication #42783
+67
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Instead of doing retries on 401 errors, use a mechanism from client-go which simply reloads the token periodically in the background. Also, don't stop logging errors after the first 401. These errors, if present, need to be addressed by the cluster operator, so we should make them more prominent. (cherry picked from commit c61c0fe)
mergify
bot
requested review from
rdner and
faec
and removed request for
a team
botelastic
bot
added
the
needs_team
github-actions
bot
added
enhancement
cleanup
Team:Cloudnative-Monitoring
botelastic
bot
removed
the
needs_team
pierrehilbert
added
Team:obs-ds-hosted-services
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pierrehilbert
requested review from
swiatekm
and removed request for
rdner and
faec
swiatekm
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
[metricbeat] Refactor kubernetes bearer token authentication
Instead of doing retries on 401 errors, use a mechanism from client-go which simply reloads the token periodically in the background.
Also, don't stop logging errors after the first 401. These errors, if present, need to be addressed by the cluster operator, so we should make them more prominent.
We have a report of the current mechanism running into race conditions in some OpenShift clusters. The exact root cause is unknown, but this change should address it.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
After this change, we will continue logging errors when we get a 401 from the API Server of kubelet, whereas up until now we'd only log the first one.
How to test this PR locally
mage package.Related issues
This is an automatic backport of pull request #42714 done by [Mergify](https://mergify.com).