{filebeat/winlogbeat} Extract runner logic for eventlog #42736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
enhancement
Filebeat
botelastic
bot
added
needs_team
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
matthewscherer
approved these changes
Feb 18, 2025
AndersonQ
reviewed
Feb 20, 2025
AndersonQ
approved these changes
Feb 20, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Extract runner logic for eventlog * do not use unnecessary runner struct * fix lint * Recover file (cherry picked from commit a28ac4c)
4 tasks
marc-gr
added a commit
that referenced
this pull request
Feb 20, 2025
) * Extract runner logic for eventlog * do not use unnecessary runner struct * fix lint * Recover file (cherry picked from commit a28ac4c) Co-authored-by: Marc Guasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Reduce duplicated code by reusing running logic for event logs.
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs