Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 10x130 interpolated beamline to enable normal usage like other en… #839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajentsch
Copy link
Contributor

@ajentsch ajentsch commented Mar 7, 2025

…ergies

Briefly, what does this PR introduce?

This PR introduces a 10x130 lattice which has been calculated via interpolation between the three "core" beam energy settings, while still keeping the B0 constant. This will be paired with a similar PR for the RP matrices in EICrecon.

This updated magnet setting file will allow for "normal" usage of the file, where the B0 and RP can be used simultaneously.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [ x] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • [ x] Tests for the changes have been added
  • Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No, improves performance.

Does this PR change default behavior?

Yes, it changes the default 10x130 magnet settings to something which can be properly used.

@ajentsch
Copy link
Contributor Author

ajentsch commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant