This repository was archived by the owner on Feb 20, 2019. It is now read-only.
WIP: Working on code coverage. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 56 57 +1
Lines 189 192 +3
=====================================
+ Hits 189 192 +3
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working through the video series, which is very informative btw. It seems that after reviewing step 8 on the contributing.md I may of skipped on using the
npm run commitfor creating the commit message - not sure if this aspect of the step was described in the video series, was hoping you could tell me what steps to take if it happened to be a requirement.I did use the
npm run commitwhen going through this earlier and thought it was a cool feature but was lost as to what to input for the scope, any help on this?Good news, it seems that the
reversefunction that was added in this pull request has passed the NPM lint script and the tests setup using the ava plugin.This pull request aims to resolve issue #154 . Thanks again for setting up this demo repo, let me know what you think.