Fix misleading 'serious error' message #88
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #88 +/- ##
===========================================
- Coverage 61.50% 61.49% -0.01%
===========================================
Files 275 275
Lines 15226 15228 +2
Branches 1551 1551
===========================================
Hits 9365 9365
- Misses 5861 5863 +2 ☔ View full report in Codecov by Sentry. |
Ozaq
force-pushed
the
fix-async-api-iterator-cancellation
branch
from
9f6f76c to
a45da83
Compare
ChrisspyB
reviewed
Feb 20, 2025
Ozaq
force-pushed
the
fix-async-api-iterator-cancellation
branch
from
a45da83 to
2d237d7
Compare
Indeed. I considered another approach but that's a discussion that we need to have in a different context. Right now this change is just cosmetics. |
Ozaq
force-pushed
the
fix-async-api-iterator-cancellation
branch
from
2d237d7 to
523f00a
Compare
|
Addressed comment by @simondsmart to subclass |
During destruction of an AsyncApiIterator an SeriousBug exception is created if the writer task has not yet pushd all output into the shared eckit::Queue. Sending a SeriousBug exception to the writing thread, via eckit::Queue::interrupt, safely stops writing by unwinding the stack until the SeriousBug exception was silently caught in the wrapping lambda. The issue has been that on construction of a SeriousBug exception error message and stack trace are logged. This implies to the user that a serious defect was encountered when in fact everything is fine. This change is a bit of a hack as it still uses throwing an exception from the queue on write but now will use an exception that does not log anything. Fixes: FDB-405
Ozaq
force-pushed
the
fix-async-api-iterator-cancellation
branch
from
523f00a to
fa62f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During destruction of an AsyncApiIterator an SeriousBug exception is created if the writer task has not yet pushd all output into the shared eckit::Queue. Sending a SeriousBug exception to the writing thread, via eckit::Queue::interrupt, safely stops writing by unwinding the stack until the SeriousBug exception was silently caught in the wrapping lambda.
The issue has been that on construction of a SeriousBug exception error message and stack trace are logged. This implies to the user that a serious defect was encountered when in fact everything is fine.
This change is a bit of a hack as it still uses throwing an exception from the queue on write but now will use an exception that does not log anything.
Fixes: FDB-405