Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set null instead of undefined in V8Objects for null values in Java Map #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set null instead of undefined in V8Objects for null values in Java Map #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/eclipsesource/v8/utils/V8ObjectUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ private static Object getV8Result(final V8 v8, final Object value, final Map<Obj
@SuppressWarnings({ "unchecked", "rawtypes" })
private static void pushValue(final V8 v8, final V8Array result, final Object value, final Map<Object, V8Object> cache) {
if (value == null) {
result.pushUndefined();
result.pushNull();
} else if (value instanceof Integer) {
result.push((Integer) value);
} else if (value instanceof Long) {
Expand All @@ -396,7 +396,7 @@ private static void pushValue(final V8 v8, final V8Array result, final Object va
@SuppressWarnings({ "unchecked", "rawtypes" })
private static void setValue(final V8 v8, final V8Object result, final String key, final Object value, final Map<Object, V8Object> cache) {
if (value == null) {
result.addUndefined(key);
result.addNull(key);
} else if (value instanceof Integer) {
result.add(key, (Integer) value);
} else if (value instanceof Long) {
Expand Down