-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP De-plexus Tycho #4212
base: main
Are you sure you want to change the base?
WIP De-plexus Tycho #4212
Conversation
Test Results 603 files ± 0 4 errors 599 suites - 4 3h 25m 52s ⏱️ - 58m 14s For more details on these parsing errors, failures and errors, see this check. Results for commit 924293d. ± Comparison against base commit 6c80860. This pull request removes 23 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
public class DefaultRepositoryIdManager implements IRepositoryIdManager { | ||
private final Logger logger = LoggerFactory.getLogger(getClass()); | ||
|
||
// TODO: wut? repositoryIds may CHANGE per project, as project may define new ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven wants server-id to get authenticaction / proxy infos, as P2 repository has no ID we let this component "learn" what URI was used in a given id context (e.g. pom or target file), so later we can map them back to ask if maven has credentials for that ID.
As credential IDs are global one can't use different credentials/mirrors/proxy per ID and even if in theory it could be different per project this actually won't work well
@laeubi updated with latest main |
Applied https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup Changes: * removed ol' Plexus * and related classes like Logger, Disposable, etc
There are already a bunch of conflicts and the patch is huge. Would you please submit it in smaller chunks so things can be actually merged? |
@laeubi you ported these or should I try to rebase? |
@cstamas I have ported some of the changes (but not all) and at least sometimes look at your changes to get an idea how to convert things, so if you want to take the effort a rebase would be useful. What @akurtakov want to say is maybe its better to just "deplexus" one little part/component (so it can even be merged) instead of one big change but you can of course decide. |
Applied https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup
Changes:
Is WIP and will fail, build is OK up to OSGi compiler plugin subproject currently.