-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open local workspaces, files and folders in remote #14607
Open
jonah-iden
wants to merge
5
commits into
master
Choose a base branch
from
jiden/open-local-workspaces-in-remote
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Dec 11, 2024
@jonah-iden What is the state of this PR? |
@JonasHelming Seems i've forgotten about this one. Still need adress the review comments. I'll try and take care of that next time i have some open-source time |
4706cbc
to
0d8373b
Compare
0d8373b
to
57016e6
Compare
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
@jonah-iden Ping :-) |
@JonasHelming already requested a re-review. But thanks for the ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implements #14574
This does 2 things regarding opening workspaces when connected to a remote.
open recent workspaces
and allows opening them even when connected to a remoteHow to test
Connect to a remote or dev-container.
select
file -> Open Recent Workspace...
see the list should be equal to the list you see locally.
Workspaces should be openable both dev-container and normal files/folders
Connect to a remote or dev-container.
use the
file -> Open Folder...
option.See there should be a new button
Show Local
Click to see a new file dialog opening showing the local file system
Selecting the folder disconnects the remote and opens the workspace or opens a new window with the selected workspace (depending on settings)
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers