Welcome Widget: Mark recent workspaces as DevContainer #14595
Merged
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbicker
force-pushed
the
jbicker/show-devcontainer-in-welcome-recentlist
branch
3 times, most recently
from
cd8ffb2 to
8f12c49
Compare
jonah-iden
reviewed
Dec 6, 2024
There was a problem hiding this comment.
i think it would be nicer to have still have the local workspace path in the grey text and the devcontainer info in the blue clickable one. And then don't use the full devcontainer.json path. Maybe just either the name of the directory its in or just [Dev Container] if there only is one devcontainer file without subdirectories in the .devcontainer folder
jbicker
force-pushed
the
jbicker/show-devcontainer-in-welcome-recentlist
branch
from
8f12c49 to
ed4fc3c
Compare
|
@jonah-iden What is the state of this PR? |
|
@JonasHelming Just talked with Jan about this yesterday. I will do another review at some point today and then it should be ready to be merged |
jonah-iden
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In Recent Workspaces List in Welcome Widget workspaces which were recently opened in a DevContainer are marked as such.
How to test
Open a workspace in DevContainer. Reopen the Theia app and see the last workspace marked as DevContainer.
Review checklist
Reminder for reviewers