Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): null check at /summaryAdministration #2946

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Mar 3, 2025

Add a null check at /projects/{id}/summaryAdministration endpoint for License Info Header.

Suggest Reviewer

@keerthi-bl

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 3, 2025
keerthi-bl
keerthi-bl previously approved these changes Mar 5, 2025
Copy link
Contributor

@keerthi-bl keerthi-bl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@keerthi-bl
Copy link
Contributor

@GMishx
Please resolve conflicts.

Testing was successful.

@keerthi-bl keerthi-bl added has merge conflicts The PR has merge conflicts and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 5, 2025
@GMishx GMishx force-pushed the fix/project/summartAdministration branch from 0572d18 to ad332b2 Compare March 6, 2025 04:38
@GMishx GMishx added ready ready to merge and removed has merge conflicts The PR has merge conflicts labels Mar 6, 2025
@GMishx
Copy link
Member Author

GMishx commented Mar 6, 2025

@keerthi-bl please review again as the rebase stale the old review comment from you :-)

Copy link
Contributor

@keerthi-bl keerthi-bl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@GMishx GMishx merged commit 5b3535a into eclipse-sw360:main Mar 10, 2025
3 checks passed
@GMishx GMishx deleted the fix/project/summartAdministration branch March 10, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants