feat(rest): delete a vendor by id. #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudra-superrr
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
rudra-superrr
removed request for
heliocastro,
ag4ums,
GMishx,
KoukiHama and
arunazhakesan
rudra-superrr
force-pushed
the
feat/deleteVendor
branch
from
a425f91
to
0c2d9ea
Compare
rudra-superrr
added
needs code review
needs general test
rudra-superrr
force-pushed
the
feat/deleteVendor
branch
from
0c2d9ea
to
1d13688
Compare
rudra-superrr
force-pushed
the
feat/deleteVendor
branch
from
1d13688
to
32aac0f
Compare
GMishx
reviewed
Oct 17, 2024
...urce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/vendor/VendorController.java
Outdated
Show resolved
Hide resolved
rudra-superrr
force-pushed
the
feat/deleteVendor
branch
from
32aac0f
to
c669c9f
Compare
|
@rudra-superrr please resolve merge conflicts. @keerthi-bl please test the PR. |
Signed-off-by: Rudra Chopra <[email protected]>
rudra-superrr
force-pushed
the
feat/deleteVendor
branch
from
c669c9f
to
071744c
Compare
|
Test successful.
|
GMishx
removed
the
needs general test
GMishx
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Approved by @keerthi-bl here: #2626 (comment)
@keerthi-bl , please use "Review changes" feature of GitHub to approve/request changes on PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2624
Description: run the endpoint to delete a vendor by id.