-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest) : Rest Api for ECC page #2244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a192df
to
cf35e07
Compare
4f9c92b
to
5adc185
Compare
Merge conflicts resolved |
...resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccService.java
Outdated
Show resolved
Hide resolved
...resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccService.java
Outdated
Show resolved
Hide resolved
...resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccService.java
Outdated
Show resolved
Hide resolved
...resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccService.java
Outdated
Show resolved
Hide resolved
...ource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccController.java
Outdated
Show resolved
Hide resolved
...resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/ecc/SW360EccService.java
Outdated
Show resolved
Hide resolved
4e3c740
to
71952cf
Compare
Addressed all the review comments. |
One thing, request structure and response structure fields are not shown in api docs. |
71952cf
to
ea9edb7
Compare
Review comment addressed. |
ea9edb7
to
ef7b82b
Compare
…ncorrect-error-displayed-during-comp-creation-2215 fix(importCDX): Update failed component creation error message Reviewed by: [email protected] Tested by: [email protected]
ef7b82b
to
df2ffc3
Compare
Code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#2036
Suggest Reviewer
How To Test?
http://localhost:8080/resource/api/ecc?page=0&page_entries=3&sort=name%2Cdesc
Sample response :
{
"_embedded": {
"sw360:jSONObjects": [
{
"assessor_contact_person": "",
"name": "compfeb2 (50)",
"DT_RowId": "d29b5995f30146e5ad30b84a35f42112",
"id": "d29b5995f30146e5ad30b84a35f42112",
"version": "50",
"assessor_dept": "",
"status": "OPEN",
"group": "",
"assessment_date": ""
},
{
"assessor_contact_person": "",
"name": "Test Compo 2023 1 (22.23)",
"DT_RowId": "e06f3a093ca1453085fd27c0017e6e2c",
"id": "e06f3a093ca1453085fd27c0017e6e2c",
"version": "22.23",
"assessor_dept": "",
"status": "OPEN",
"group": "",
"assessment_date": ""
},
{
"assessor_contact_person": "[email protected]",
"name": "Component5.19 (1.1)",
"DT_RowId": "2e7f86c8236e4dd299328cbe3f7f7ae0",
"id": "2e7f86c8236e4dd299328cbe3f7f7ae0",
"version": "1.1",
"assessor_dept": "DEPARTMENT",
"status": "REJECTED",
"group": "",
"assessment_date": "2023-02-03"
}
]
},
"_links": {
"first": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"previous": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"last": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"curies": [
{
"href": "http://localhost:8080/resource/docs/{rel}.html",
"name": "sw360",
"templated": true
}
]
},
"page": {
"size": 3,
"totalElements": 3,
"totalPages": 1,
"number": 1
}
}
Checklist
Must: