Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): New end point for downloading project reports. #1902

Merged
merged 2 commits into from
Jun 26, 2023
Merged

feat(rest): New end point for downloading project reports. #1902

merged 2 commits into from
Jun 26, 2023

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

Issue:
#1901

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

It can be tested using postman or any other supporting API platform.

URL : http://localhost:8080/resource/api/reports/projects?withlinkedreleases=true&mimetype=xlsx&mailRequest=true

Response : E-mail sent succesfully to the end user.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added New-UI Level for the API and UI level changes for the new-ui needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST labels Apr 12, 2023
@rudra-superrr
Copy link
Contributor

Please change the file name that we download to projects-yyyy-mm-dd format.
Also remove the mimetype txt from the documentation.

@keerthi-bl keerthi-bl force-pushed the fix/myprojects branch 4 times, most recently from 614ce1a to 33542e2 Compare May 6, 2023 10:58
@keerthi-bl
Copy link
Contributor Author

Please change the file name that we download to projects-yyyy-mm-dd format. Also remove the mimetype txt from the documentation.

Completed

@keerthi-bl keerthi-bl closed this May 8, 2023
@keerthi-bl
Copy link
Contributor Author

Please change the file name that we download to projects-yyyy-mm-dd format. Also remove the mimetype txt from the documentation.

Changes done

@keerthi-bl keerthi-bl reopened this May 8, 2023
@smrutis1 smrutis1 self-requested a review May 8, 2023 07:55
@keerthi-bl keerthi-bl changed the title feat(rest):New end point for dowloading projects feat(rest):New end point for dowloading project Reports May 9, 2023
@keerthi-bl keerthi-bl changed the title feat(rest):New end point for dowloading project Reports feat(rest): New end point for downloading project reports. May 9, 2023
@rudra-superrr
Copy link
Contributor

Hi @keerthi-bl ,
Docs for this endpoint are broken.

image

@keerthi-bl
Copy link
Contributor Author

Hi @keerthi-bl , Docs for this endpoint are broken.

image

Fixed

@keerthi-bl keerthi-bl mentioned this pull request May 17, 2023
Merged
1 task
@rudra-superrr
Copy link
Contributor

Testing was successful.

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label May 17, 2023
smrutis1
smrutis1 requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the review comments along with, kindly check the indentation in most of the places.

backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java Outdated Show resolved Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java Outdated Show resolved Hide resolved
...erver/src/main/java/org/eclipse/sw360/rest/resourceserver/component/ComponentController.java Outdated Show resolved Hide resolved
...server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportController.java Outdated Show resolved Hide resolved
...server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportController.java Outdated Show resolved Hide resolved
...server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportController.java Outdated Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportService.java Outdated Show resolved Hide resolved
...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ProjectSpecTest.java Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportService.java Show resolved Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java Outdated Show resolved Hide resolved
@smrutis1
Copy link
Contributor

Please update the commit message.
image

@keerthi-bl
Copy link
Contributor Author

Review comments addressed

smrutis1
smrutis1 requested changes May 29, 2023
View reviewed changes
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java Outdated Show resolved Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java Outdated Show resolved Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectRepository.java Outdated Show resolved Hide resolved
backend/src/src-projects/src/main/java/org/eclipse/sw360/projects/ProjectHandler.java Outdated Show resolved Hide resolved
...server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportController.java Outdated Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportService.java Outdated Show resolved Hide resolved
@keerthi-bl keerthi-bl force-pushed the fix/myprojects branch 4 times, most recently from 0e2bebf to c619397 Compare June 2, 2023 05:44
@keerthi-bl
Copy link
Contributor Author

All the review comments addressed.

@keerthi-bl keerthi-bl force-pushed the fix/myprojects branch 2 times, most recently from a4f66e8 to 7d521e8 Compare June 6, 2023 10:28
@keerthi-bl
Copy link
Contributor Author

All the review comments addressed.
Changes : Added documentation as per the review comment.

@keerthi-bl keerthi-bl force-pushed the fix/myprojects branch 3 times, most recently from 15357ad to f9be8a7 Compare June 13, 2023 13:20
smrutis1
smrutis1 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok. As per the discussion there will be another PR to make the email download link asynchronous.

@smrutis1
Copy link
Contributor

smrutis1 commented Jun 21, 2023 •
edited
Loading

Just noticed it. Kindly fix it

image

@keerthi-bl
Copy link
Contributor Author

changes done!

@ag4ums @keerthi-bl
Merge pull request eclipse-sw360#1895 from siemens/fix/summaryandadmi…
4cd6d24 
…nistrativeInfo

fix(rest): Added endpoint url for summary and administration page info

Reviewed by: [email protected]
Tested by: [email protected]
@ag4ums ag4ums merged commit a47d6c3 into eclipse-sw360:main Jun 26, 2023
1 check passed
keerthi-bl pushed a commit to siemens/sw360 that referenced this pull request Jun 27, 2023
@ag4ums @keerthi-bl
Merge pull request eclipse-sw360#1902 from siemens/fix/myprojects
ddf974b 
feat(rest): New end point for downloading project reports.

Reviewed by: [email protected]
Tested by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smrutis1 smrutis1 smrutis1 approved these changes

Assignees
No one assigned
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keerthi-bl @rudra-superrr @smrutis1 @ag4ums