[Debug ]Removal of Deprecated Constants #1784
Open
+11
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mickaelistria , could you please check this when you have time ? |
SougandhS
force-pushed
the
Deprecation_deletion
branch
from
18d4b04 to
ad147ab
Compare
| * @deprecated Replaced by {@link IDebugUIConstants#COLUMN_ID_VARIABLE_NAME} | ||
| */ | ||
| @Deprecated | ||
| public final static String COLUMN_VARIABLE_NAME = IDebugUIConstants.COLUMN_ID_VARIABLE_NAME; |
There was a problem hiding this comment.
This would break CDT, see
https://github.com/eclipse-cdt/cdt/blob/fd56a4ee112974c345bbb67fa939dea178494c00/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/IDebugVMConstants.java#L43
@jonahgraham : FYI.
I believe we first should make sure CDT would remove the reference to this constant. Already shipped CDT versions should be fine, as the constant value should be inlined by compiler.
There was a problem hiding this comment.
In progress: eclipse-cdt/cdt#1131
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Apr 8, 2025
This commit removes the deprecated constants in VariableColumnPresentation and updates references in DefaultVariableCellModifier and WatchExpressionCellModifier to use the new constants.
SougandhS
force-pushed
the
Deprecation_deletion
branch
from
ad147ab to
0a79341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated constants in VariableColumnPresentation and updates references in DefaultVariableCellModifier and WatchExpressionCellModifier to use the new constants.