Edge callback listener execution async #1973
Draft
+108
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 539 files ±0 539 suites ±0 35m 35s ⏱️ + 3m 39s For more details on these failures, see this check. Results for commit e67bde7. ± Comparison against base commit 3670670. ♻️ This comment has been updated with latest results. |
amartya4256
force-pushed
the
amartya4256/edge_callback_listener_execution_async
branch
from
afa88d8 to
c6af804
Compare
amartya4256
force-pushed
the
amartya4256/edge_callback_listener_execution_async
branch
from
c6af804 to
6cd6756
Compare
This commit cotributes to executing the registered listeners of Edge browser on Browser callbacks in a asynchronous fashion making sure no WebView related task is executed while a WebView callback is already executing making sure there's no deadlock. contributes to eclipse-platform#1771 and eclipse-platform#1919
fedejeanne
force-pushed
the
amartya4256/edge_callback_listener_execution_async
branch
from
6cd6756 to
e67bde7
Compare
fedejeanne
reviewed
Apr 3, 2025
There was a problem hiding this comment.
I think this PR does 2 things, right?
- It changes the strategy about how to execute callbacks by introducing the method
executeAsynchronously(...) - It executes some new blocks of code asynchronously by using the new method
Would it be possible to split it in 2 different PRs? That way it would be possible to see for example which part of these changes (1. or 2.) fixes the tests and which part makes it easier to work with the code.
Comment on lines
+1374
to
+1377
| for (VisibilityWindowListener showListener : other.visibilityWindowListeners) { | ||
| showListener.show(showEvent); | ||
| if (other.browser.isDisposed()) return; | ||
| } |
There was a problem hiding this comment.
The indentation is wrong here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By construct, WebView serializes all the tasks. Amidst a callback from Webview like DocumentTitleChanged, NavigationCompleted, AcceleratorKeyPressed, etc, if an EventListener is called which then calls for a method like execute or evaluate which are supposed to execute synchronously, they wait for the already executing webview task (the callback) to finish and the callback can't finish as it is waiting for the webview task to execute. Hence, this leads to a deadlock - leading to a UI freeze and then an Operation Timeout.
This PR cotributes to executing the registered listeners of Edge browser on Browser callbacks in a asynchronous fashion making sure no WebView related task is executed while a WebView callback is already executing making sure there's no deadlock.
Since the listener is called on a cllabck from webview, there is no harm to execute it asynchronously on the display thread as well as it imitates an asynchronous behaviour already. The callback is marked handled by executing ICoreWebView2*EventArgs::put_handled in all the callbacks. Hence we can call the listeners asynchronously and call ICoreWebView2*EventArgs::put_handled to mark to finish the execution of the callback.
contributes to
#1771 and
#1919