[win32] Make Font#extractZoom device independent #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 539 files ±0 539 suites ±0 27m 34s ⏱️ - 1m 9s For more details on these failures, see this check. Results for commit ce0609f. ± Comparison against base commit 97f8a2e. ♻️ This comment has been updated with latest results. |
HeikoKlare
reviewed
Mar 25, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Font.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
win32-font-extractZoom
branch
2 times, most recently
from
574cfef to
0cd173d
Compare
This commit ensures the zoom calculation for a device is device independent again. The previous logic didn't provide any advantages anymore after the conversion between points and pixels was changed for Fonts. By using DPIUtil#getNativeZoom the most probable value for the zoom of a new font a chosen.
HeikoKlare
force-pushed
the
win32-font-extractZoom
branch
from
0cd173d to
ce0609f
Compare
HeikoKlare
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Reason for the change is sound and this avoids thread access errors when creating fonts with a wrong or null device (which was also gracefully accepted in the past).
Failing test is unrelated and documented: #1843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures Font#extractZoom is device independent. The previous logic didn't provide any advantages anymore after the conversion between points and pixels was changed for Fonts. By using DPIUtil#getNativeZoom the most probable value for the zoom of a new font a chosen.