Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move return outside of else #1927

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

fedejeanne
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Test Results

   539 files   -  6     539 suites   - 6   28m 40s ⏱️ +11s
 4 330 tests  - 37   4 320 ✅  - 35    9 💤  - 3  1 ❌ +1 
16 579 runs   - 37  16 477 ✅  - 35  101 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c827ee6. ± Comparison against base commit 72695f8.

This pull request removes 37 tests.
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

♻️ This comment has been updated with latest results.

@fedejeanne
Copy link
Contributor Author

Test failure is unrelated #1843

@fedejeanne
Copy link
Contributor Author

FTR the build failure is probably a non-issue (see https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5714#note_3395580) but since this PR is not urgent, I'll wait for the Help Desk issue to be worked on and the build be fixed.

@fedejeanne
Copy link
Contributor Author

No point in using resources to test this change. The infrastructure seems a bit flaky at the moment and hogging resources doesn't help.

@fedejeanne fedejeanne merged commit da4cbaa into eclipse-platform:master Mar 31, 2025
9 of 15 checks passed
@fedejeanne fedejeanne deleted the outside_else branch March 31, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant