Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win32] Create ImageData based image handles on demand #1909

Merged
merged 1 commit into from
Mar 25, 2025
Merged

[win32] Create ImageData based image handles on demand #1909

merged 1 commit into from
Mar 25, 2025

Conversation

akoch-yatta
Copy link
Contributor

@akoch-yatta akoch-yatta commented Mar 17, 2025 •
edited by fedejeanne
Loading

This PR refactors the Image constructors using plain ImageData to create all handles on demand instead of creating a first handle in the constructor.

Requires

This was linked to issues Mar 17, 2025
Dynamize Image constructors with ImageData vi-eclipse/Eclipse-Platform#198
Closed
Dynamize Image constructors with filename and InputStream vi-eclipse/Eclipse-Platform#262
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

Test Results

   539 files   -  6     539 suites   - 6   30m 6s ⏱️ + 1m 50s
 4 328 tests  - 37   4 314 ✅  - 35   13 💤  - 3  1 ❌ +1 
16 563 runs   - 37  16 451 ✅  - 35  111 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c3e236a. ± Comparison against base commit 329ed24.

This pull request removes 37 tests. 
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

♻️ This comment has been updated with latest results.

@akoch-yatta akoch-yatta force-pushed the image-with-imagedata-provider branch 3 times, most recently from 64c06c4 to 044cb7c Compare March 17, 2025 15:15
@fedejeanne fedejeanne mentioned this pull request Mar 20, 2025
Merged
@akoch-yatta akoch-yatta force-pushed the image-with-imagedata-provider branch 2 times, most recently from 6b38e27 to f6bc167 Compare March 21, 2025 11:28
@akoch-yatta akoch-yatta marked this pull request as ready for review March 21, 2025 11:42
@akoch-yatta akoch-yatta force-pushed the image-with-imagedata-provider branch from f6bc167 to 90c6c9d Compare March 21, 2025 12:12
@akoch-yatta akoch-yatta force-pushed the image-with-imagedata-provider branch 3 times, most recently from 0e4765d to 1bdc8e6 Compare March 25, 2025 14:53
@akoch-yatta
[win32] Create ImageData based image handles on demand
c3e236a 
This commit refactors the Image constructors using plain ImageData to
create all handles on demand instead of creating a first handle in the
constructor.
@akoch-yatta akoch-yatta force-pushed the image-with-imagedata-provider branch from 1bdc8e6 to c3e236a Compare March 25, 2025 16:14
@HeikoKlare
Copy link
Contributor

Failing test is unrelated and documented: #1843

@HeikoKlare HeikoKlare merged commit 7c818d6 into eclipse-platform:master Mar 25, 2025
13 of 15 checks passed
@HeikoKlare HeikoKlare deleted the image-with-imagedata-provider branch March 25, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamize Image constructors with filename and InputStream Dynamize Image constructors with ImageData
2 participants
@akoch-yatta @HeikoKlare