[Win32] Combine duplicate initialization logic for image from providers #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 505 files ±0 505 suites ±0 7m 50s ⏱️ -54s For more details on these failures, see this check. Results for commit 14056ad. ± Comparison against base commit d25bdc3. ♻️ This comment has been updated with latest results. |
|
@akoch-yatta can you please have a look at this and check whether you see any reasons against this simplification? |
HeikoKlare
force-pushed
the
win32-image-unify-duplicate-initialization
branch
2 times, most recently
from
6787b44 to
1033752
Compare
akoch-yatta
approved these changes
Mar 8, 2025
Images based on ImageFileNameProvider and ImageDataProvider are initialized with data based on the default zoom and can later on be reinitialized with data for others zooms when `getImageData()` is called. At both places, the same functionality is implemented twice. This change makes the initial creation of image data use the already existing implementation for reinitializing it for another zoom. It also unifies the previous two implementations and removes obsolete calls to init() which are just required once for starting resource tracking.
HeikoKlare
force-pushed
the
win32-image-unify-duplicate-initialization
branch
from
1033752 to
14056ad
Compare
|
Failing test is unrelated and already documented: #1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images based on ImageFileNameProvider and ImageDataProvider are initialized with data based on the default zoom and can later on be reinitialized with data for others zooms when
getImageData()is called. At both places, the same functionality is implemented twice.This change makes the initial creation of image data use the already existing implementation for reinitializing it for another zoom. It also unifies the previous two implementations and removes obsolete calls to init() which are just required once for starting resource tracking.
Required to keep changes in #1828 simple.