-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[win32] Scale up bounds as rectangle in GC #1762
[win32] Scale up bounds as rectangle in GC #1762
Conversation
Test Results 501 files - 1 501 suites - 1 8m 10s ⏱️ -37s For more details on these failures, see this check. Results for commit 10ed8b5. ± Comparison against base commit 705f8c4. This pull request removes 37 tests.
♻️ This comment has been updated with latest results. |
ed71087
to
688fb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit adresses render artifacts visible when drawing on a GC with monitor-specific scaling enabled e.g. on 175%. Reason is that scaling up all attributes of bounds separately can lead to rounding errors e.g. between y and height (one being scaled up, the other one not). Scaling them together as a rectangle solves this limitation.
688fb60
to
10ed8b5
Compare
Failing test is known as randomly failing and documented: #1843 |
This commit adresses render artifacts visible when drawing on a GC with monitor-specific scaling enabled e.g. on 175%. Reason is that scaling up all attributes of bounds separately can lead to rounding errors e.g. between y and height (one being scaled up, the other one not). Scaling them together as a rectangle solves this limitation.
This PR is not yet meant to be merged, it should be used to test different scenarios where the GC is involved on uneven zoom settings like 125% or 175%.