-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide auto completion for bnd instructions in maven xml documents #1888
Conversation
Test Results 321 files ±0 321 suites ±0 51m 34s ⏱️ + 4m 40s For more details on these failures and errors, see this check. Results for commit d7f60f6. ± Comparison against base commit 673fc5b. ♻️ This comment has been updated with latest results. |
081faee
to
daaa517
Compare
This is currently quite basic and not super-smart, but will open up a whole bunch of new things to support, e.g. the next thing would be to add diagnostics to one can get errors, warnings and so on. I therefore plan to merge this after the next m2e release for 2024-12 so we can further improve / experiment with that! |
That's really good, it does make things better. It's still not immune to libraries incompatibilities inside LemMinX process though, but that's another story. |
Yes it makes it just a little bit easier now from a deployment perspective as one does not need to collect everything manually. For more one would need to change how lemminx itself is launched, e.g if everything would be embedded inside the bundle (as with a very minimal example here) and only imports what is required to share the API then one could probably make it an connect-osgi-framework where each extension is its own bundle and encapsulates all requirements except the shared classes like lsp4j... |
47ff9ce
to
10faeb6
Compare
10faeb6
to
c5028e6
Compare
I have now rebased and adjusted this, due to a bug in PDE this currently not working smooth during development in the IDE: |
7b44d8b
to
e0ac639
Compare
The bnd-maven and felix-bundle plugin provide a way to use bnd-instructions to build OSGi bundles. As this is a complex syntax that can not be expressed as regular maven-mojo configuration lemminx-maven can not supply any useful completions. This adds a new lemminx-extension that provides such completions in a very basic way to support people writing such custom configuration. Signed-off-by: Christoph Läubrich <[email protected]>
e0ac639
to
d7f60f6
Compare
The bnd-maven and felix-bundle plugin provide a way to use bnd-instructions to build OSGi bundles. As this is a complex syntax that can not be expressed as regular maven-mojo configuration lemminx-maven can not supply any useful completions.
This adds a new lemminx-extension that provides such completions in a very basic way to support people writing such custom configuration.
Here is a little video showing the new completion support:
Peek.2024-11-15.17-45.mp4
@mickaelistria this shows how to deploy a lemminx-extension as a regular bundle inside m2e and providing additional jars to the flat-classpath using OSGi wiring API