Add publish package workflow #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydar-metin
force-pushed
the
release-runner
branch
from
f133481 to
7f8c88c
Compare
.github/workflows/publish.yml
Outdated
| - name: Publish | ||
| run: yarn publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Suggested change
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |
| NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN}} |
For consistency with other CIs. See for example here: https://github.com/eclipse-cdt-cloud/.eclipsefdn/blob/4d17aa1bc29321c976a319e110d118241af8415e/otterdog/eclipse-cdt-cloud.jsonnet#L137
I believe we need to raise a PR for the above file to add the token. I assume using the same "value" as in above referenced example (the bot thingy).
There was a problem hiding this comment.
@planger could you take a look?
There was a problem hiding this comment.
Happy to open a PR. But may need @planger 's approval as project lead anyway.
There was a problem hiding this comment.
haydar-metin
force-pushed
the
release-runner
branch
from
95bd5e7 to
87725e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildstage asyarn publishwill do a clean build.Merge after #2