OMR: Add new zos 3.1 systems #434
Conversation
|
@jdekonin for review since he is setting up the new nodes. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7356849 | Triggered | Generic Password | 2a72e90 | instances/technology.omr/jenkins/configuration.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
@AdamBrousseau any news here? |
|
I think we were having issues setting up the new machines. I will let you know when this is ready. Thanks for the bump. |
|
Ok. No problem. |
|
I have 1 of the 2 setup, the second one will be done later today or tomorrow. Unless there is issue with jenkins attempting to connect to a node until its 100% online, I'd say go ahead and merge. Edit: well, maybe take out of draft and rebase first. |
|
There is no hurry (at least from my side 🙂 ). So I can wait until you're done with both machines. |
| value: 'txt' | ||
| - key: "_TAG_REDIR_OUT" | ||
| value: 'txt' | ||
| - key: "LIBPATH" |
There was a problem hiding this comment.
rocket references can be removed
| - key: "PATH" | ||
| value: '/u/user1/jenkins-zos:$PATH' | ||
| - key: "PERL5LIB" | ||
| value: '/openzdk/rocket/lib/perl5' |
There was a problem hiding this comment.
not sure we use perl anymore but this isn't the correct location if it is. remove and we'll re-add if it is needed later
There was a problem hiding this comment.
The builds looks for perl so I'm guessing it is being used.
10:41:44 -- Found Perl: /usr/bin/perl (found version "5.30.0")
What should it be updated to?
| - toolLocation: | ||
| locations: | ||
| - home: '/u/user1/jenkins-zos/git' | ||
| key: "hudson.plugins.git.GitTool$DescriptorImpl@Default" |
There was a problem hiding this comment.
Using zopen version of git now which is found on the PATH. I believe this can just be removed.
Copy from existing zos machines. Remove unneeded java8 tool. Remove rocket tools and old cmake version from PATH. Remove rocker from LIBPATH. Update Perl lib path. Remove git tool as it is now default on PATH. Issue runtimes/infrastructure 9263 Signed-off-by: Adam Brousseau <[email protected]>
|
@fredg02 for merge please |
|
Change has been merged and deployed. |
Issue runtimes/infrastructure 9263