Loop index caused solsym array to be indexed past end-of-array. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaelynlitz
reviewed
Dec 17, 2024
| @@ -297,7 +297,7 @@ void chm_diags( | |||
| // accumulators | |||
| // if (history_aerosol.and..not .history_verbose) then | |||
|
|
|||
| for (int nn = lchnk; nn < pcnst; nn++) { | |||
| for (int nn = lchnk; nn < gas_pcnst; nn++) { | |||
There was a problem hiding this comment.
Maybe the real discrepancy is that in this file we set pcnst to 80, but in the validation test, we use pcsnt = 41? I agree that solsym is length gas_pcnst but fldcw can technically be length pcnst ?
There was a problem hiding this comment.
Yes, there is something wrong with the length of fldcw. There was a note that setting the length to 80 was somewhat of a guess as it was not obvious in the Fortran code what length to use. Maybe we should ask Balwinder when he gets back?
There was a problem hiding this comment.
That sounds like a good plan
* Add limiting to avoid indexing past end of array. * Add limiting to avoid indexing past end of array. * Add limiting to avoid indexing past end of array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.