Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change old variable name 'pver' to new and improved 'nlev'. #374

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

overfelt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 86.88525% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (e26b5b6) to head (11658d2).

Files with missing lines Patch % Lines
src/mam4xx/mo_chm_diags.hpp 36.36% 14 Missing ⚠️
src/mam4xx/mo_setext.hpp 75.00% 1 Missing ⚠️
src/mam4xx/mo_sethet.hpp 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          45       45           
  Lines        9339     9339           
=======================================
  Hits         8955     8955           
  Misses        384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, James!

overfelt and others added 12 commits January 9, 2025 10:08
…ics.

Add function (mmr2vmr_col) to compute VMR for an entire column.

Switch to ConstColumnView for ATM variables.

Create a sethet function with work arrays and a smaller number of inputs.

Rename sethet to sethet_detail.

Use View2D for het_rates to avoid copying data.
* Hook up drydep interface.

* Inequality needs to be >= to account for fortran -> C++ indexing.

* Only call mam4::mo_drydep::drydep_xactive on the bottom level: nlev-1

---------

Co-authored-by: Balwinder Singh <[email protected]>
@overfelt overfelt force-pushed the jroverf/nlev_instead_of_pver branch from 11658d2 to 36bd216 Compare January 9, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants