Skip to content

Email subject and sender name option #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

Email subject and sender name option #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f0247f
Update form-submission-handler.js
ririko5834 Apr 28, 2021
f1a30d9
Update google-apps-script.js
ririko5834 Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions form-submission-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
// add form-specific values into the data
formData.formDataNameOrder = JSON.stringify(fields);
formData.formGoogleSheetName = form.dataset.sheet || "responses"; // default sheet name
formData.formGoogleEmailSubject = form.dataset.subject || "Contact form was submitted"; //default email subject
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected that we set the defaults here, or would we want to have a default like the custom email option below?

nitpick: the comment at the end matches L46, but I think it could be cleaner code to consider changing the variable names here to those, if those are better descriptions than what we have as variables in the code.

what do you think?

formData.formGoogleEmailSender = form.dataset.sender || "Contact Form"; //default email from text
formData.formGoogleSendEmail
= form.dataset.email || ""; // no email by default

Expand Down
3 changes: 2 additions & 1 deletion google-apps-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function doPost(e) {
if (sendEmailTo) {
MailApp.sendEmail({
to: String(sendEmailTo),
subject: "Contact form submitted",
name: String(e.parameters.formGoogleEmailSender) || "Contact Form",
subject: String(e.parameters.formGoogleEmailSubject) || "Contact form submitted",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these || ... checks won't get hit in all cases.

If the parameters are null or undefined, (like if someone just updates the backend script here or doesn't give these parameters), then you would end up with String(undefined) = 'undefined' which is not falsey.

It may be worth setting the name / subject above and consider using mailData and/or .toString() when the field is present/truthy.

// replyTo: String(mailData.email), // This is optional and reliant on your form actually collecting a field named `email`
htmlBody: formatMailBody(mailData, dataOrder)
});
Expand Down