Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add basic version skew detection #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josharian
Copy link
Collaborator

Version skew between go-fuzz-build and go-fuzz
is already a problem, and may get worse as
we switch go-fuzz to modules.

This change introduces simple, manual skew detection.
Hopefully this will become less manual over time,
and more sophisticated as needed.

This change will force everyone to rebuild their zip files.
But it will also tell them so, and explain why.
@thepudds
Copy link
Collaborator

thepudds commented Oct 3, 2019

Conceptually, this seems reasonable and useful, and hopefully helps with modules support introducing greater chances of version skew with modules.

The initial platforms are passing in travis...

(I did not look carefully at each line of code at this point).

@dvyukov
Copy link
Owner

dvyukov commented Oct 4, 2019

Long term it would be good to get rid of the archive as it makes integration with other systems harder.
I would inject the version into the generated main function and pass back to dep.Main. It can even make code simpler (no need to read/write files).

@josharian
Copy link
Collaborator Author

Long term it would be good to get rid of the archive as it makes integration with other systems harder.

Agreed. I don't quite know how to do this. Opened #277 for further discussion of this topic.

I would inject the version into the generated main function and pass back to dep.Main. It can even make code simpler (no need to read/write files).

That requires also serializing and passing it along to the runner. But that assumes that serialized communication is working correctly, which it might not be in the presence of version skew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants