Fix install test

dunst-project · Jan 24, 2025 · 57323a7 · 57323a7
1 parent bda7e86
commit 57323a7
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 20 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -74,6 +74,7 @@ jobs:
       CC: gcc
       EXTRA_CFLAGS: "-Werror"
       MAKE: gmake
+      INSTALL_FLAGS: -Ddm
 
     steps:
       - uses: actions/checkout@v4
@@ -83,7 +84,7 @@ jobs:
       - name: Test in FreeBSD
         uses: vmactions/freebsd-vm@v1
         with:
-          envs: "CC EXTRA_CFLAGS MAKE"
+          envs: "CC EXTRA_CFLAGS MAKE INSTALL_FLAGS"
           usesh: true
           sync: rsync
           copyback: false

diff --git a/.valgrind.suppressions b/.valgrind.suppressions
@@ -218,7 +218,6 @@
    # FreeBSD part1
    glib_leak_freebsd1
    Memchek:Leak
-   fun:*alloc
    ...
    fun:g_dbus_address_get_stream_sync
    ...
@@ -229,7 +228,6 @@
    # XXX: Why isn't memory freed in  g_bus_unown_name?
    glib_leak_freebsd2
    Memchek:Leak
-   fun:*alloc
    ...
    fun:g_bus_own_name
    ...

diff --git a/Makefile b/Makefile
@@ -223,49 +223,49 @@ clean-wayland-protocols:
 install: install-dunst install-dunstctl install-dunstrc install-service
 
 install-dunst: dunst doc
-	install -Dm755 dunst ${DESTDIR}${BINDIR}/dunst
-	install -Dm644 docs/dunst.1 ${DESTDIR}${MANPREFIX}/man1/dunst.1
-	install -Dm644 docs/dunst.5 ${DESTDIR}${MANPREFIX}/man5/dunst.5
-	install -Dm644 docs/dunstctl.1 ${DESTDIR}${MANPREFIX}/man1/dunstctl.1
-	install -Dm644 docs/dunstify.1 ${DESTDIR}${MANPREFIX}/man1/dunstify.1
+	${INSTALL} ${INSTALL_FLAGS}755 dunst ${DESTDIR}${BINDIR}/dunst
+	${INSTALL} ${INSTALL_FLAGS}644 docs/dunst.1 ${DESTDIR}${MANPREFIX}/man1/dunst.1
+	${INSTALL} ${INSTALL_FLAGS}644 docs/dunst.5 ${DESTDIR}${MANPREFIX}/man5/dunst.5
+	${INSTALL} ${INSTALL_FLAGS}644 docs/dunstctl.1 ${DESTDIR}${MANPREFIX}/man1/dunstctl.1
+	${INSTALL} ${INSTALL_FLAGS}644 docs/dunstify.1 ${DESTDIR}${MANPREFIX}/man1/dunstify.1
 
 install-dunstctl: dunstctl
-	install -Dm755 dunstctl ${DESTDIR}${BINDIR}/dunstctl
+	${INSTALL} ${INSTALL_FLAGS}755 dunstctl ${DESTDIR}${BINDIR}/dunstctl
 
 ifeq (1,${SYSCONF_FORCE_NEW})
 install-dunstrc:
-	install -Dm644 dunstrc ${DESTDIR}${SYSCONFFILE}
+	${INSTALL} ${INSTALL_FLAGS}644 dunstrc ${DESTDIR}${SYSCONFFILE}
 endif
 
 install-service: install-service-dbus
 install-service-dbus: service-dbus
-	install -Dm644 org.knopwob.dunst.service ${DESTDIR}${SERVICEDIR_DBUS}/org.knopwob.dunst.service
+	${INSTALL} ${INSTALL_FLAGS}644 org.knopwob.dunst.service ${DESTDIR}${SERVICEDIR_DBUS}/org.knopwob.dunst.service
 ifneq (0,${SYSTEMD})
 install-service: install-service-systemd
 install-service-systemd: service-systemd
-	install -Dm644 dunst.systemd.service ${DESTDIR}${SERVICEDIR_SYSTEMD}/dunst.service
+	${INSTALL} ${INSTALL_FLAGS}644 dunst.systemd.service ${DESTDIR}${SERVICEDIR_SYSTEMD}/dunst.service
 endif
 
 ifneq (0,${DUNSTIFY})
 install: install-dunstify
 install-dunstify: dunstify
-	install -Dm755 dunstify ${DESTDIR}${BINDIR}/dunstify
+	${INSTALL} ${INSTALL_FLAGS}755 dunstify ${DESTDIR}${BINDIR}/dunstify
 endif
 
 ifneq (0,${COMPLETIONS})
 install: install-completions
 install-completions:
-	install -Dm644 completions/dunst.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunst
-	install -Dm644 completions/dunstctl.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunstctl
-	install -Dm644 completions/_dunst.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunst
-	install -Dm644 completions/_dunstctl.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunstctl
-	install -Dm644 completions/dunst.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunst.fish
-	install -Dm644 completions/dunstctl.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstctl.fish
+	${INSTALL} ${INSTALL_FLAGS}644 completions/dunst.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunst
+	${INSTALL} ${INSTALL_FLAGS}644 completions/dunstctl.bashcomp ${DESTDIR}${BASHCOMPLETIONDIR}/dunstctl
+	${INSTALL} ${INSTALL_FLAGS}644 completions/_dunst.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunst
+	${INSTALL} ${INSTALL_FLAGS}644 completions/_dunstctl.zshcomp ${DESTDIR}${ZSHCOMPLETIONDIR}/_dunstctl
+	${INSTALL} ${INSTALL_FLAGS}644 completions/dunst.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunst.fish
+	${INSTALL} ${INSTALL_FLAGS}644 completions/dunstctl.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstctl.fish
 
 ifneq (0,${DUNSTIFY})
 install: install-completions-dunstify
 install-completions-dunstify:
-	install -Dm644 completions/dunstify.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstify.fish
+	${INSTALL} ${INSTALL_FLAGS}644 completions/dunstify.fishcomp ${DESTDIR}${FISHCOMPLETIONDIR}/dunstify.fish
 endif
 endif
 

diff --git a/config.mk b/config.mk
@@ -24,6 +24,10 @@ SED ?= sed
 SYSTEMDAEMON ?= systemd
 VALGRIND ?= valgrind
 
+# Provided for compatibility with BSDs
+INSTALL ?= install
+INSTALL_FLAGS ?= -Dm
+
 # Disable systemd service file installation,
 # if you don't want to use systemd albeit installed
 #SYSTEMD ?= 0