Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update Gnosis DEX models and aggregation #7920

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

mlaegn
Copy link
Contributor

@mlaegn mlaegn commented Mar 25, 2025

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Added new models for Gnosis:

  • Uniswap pools (Gnosis)
  • Honeyswap pools (Gnosis)
  • Sushiswap pools (Gnosis)
  • Levinswap pools (Gnosis)
  • Elk Finance pools (Gnosis)
  • Swapr pools (Gnosis, with dynamic fee updates joined from fee update calls)

Updated Global Dex Aggregation:
Updated dex_pools to include these new models.

Note:
Swapr pools were intentionally excluded from the dex_pools aggregation because the dynamic fee update events result in multiple rows per pool


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Mar 25, 2025
@mlaegn mlaegn marked this pull request as ready for review March 25, 2025 12:15
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Mar 25, 2025
@mlaegn mlaegn marked this pull request as draft March 25, 2025 12:20
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Mar 25, 2025
@mlaegn mlaegn changed the title Add uniswap pool info model for Gnosis Add and update Gnosis DEX models and aggregation Mar 26, 2025
@mlaegn mlaegn marked this pull request as ready for review March 27, 2025 10:06
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Mar 27, 2025
@mlaegn mlaegn marked this pull request as draft March 27, 2025 11:09
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Mar 27, 2025
@mlaegn mlaegn marked this pull request as ready for review March 27, 2025 15:34
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Mar 27, 2025
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving feedback for only first model in PR, but will apply universally 🙏

@jeff-dude jeff-dude self-assigned this Mar 27, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Mar 27, 2025
@mlaegn mlaegn requested a review from jeff-dude March 28, 2025 11:08
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you 🔥

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants