-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and update Gnosis DEX models and aggregation #7920
Open
mlaegn
wants to merge
23
commits into
duneanalytics:main
Choose a base branch
from
gnosischain:gnosis_pool_infos_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving feedback for only first model in PR, but will apply universally 🙏
dbt_subprojects/dex/models/_projects/elk_finance/elk_finance_pools.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/_projects/elk_finance/gnosis/elk_finance_gnosis_pools.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/_projects/elk_finance/gnosis/elk_finance_gnosis_pools.sql
Outdated
Show resolved
Hide resolved
jeff-dude
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
Added new models for Gnosis:
Updated Global Dex Aggregation:
Updated
dex_pools
to include these new models.Note:
Swapr pools were intentionally excluded from the dex_pools aggregation because the dynamic fee update events result in multiple rows per pool
quick links for more information: