fix solana phoenix trades and fees #7856
Open
+36
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
This reverts commit 9f626eb.
|
the PR now fixes:
https://dune.com/queries/4033552/6791501 |
github-actions
bot
added
ready-for-review
jeff-dude
requested changes
Mar 27, 2025
dbt_subprojects/solana/models/_sector/dex/dex_solana_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/solana/models/_sector/dex/dex_solana_trades.sql
Outdated
Show resolved
Hide resolved
|
on your successful run before adding full history back, why was incremental 0 rows? is v1 deprecated / no new data or a bug in code? https://github.com/duneanalytics/spellbook/actions/runs/14104627449/job/39508243312#step:15:20 |
jeff-dude
added
in review
|
I had it set to a speicific daterange outside of any if_incremental blocks so the incremental run had no data to process |
|
pushed the incremental changes 🫡 |
jeff-dude
approved these changes
Mar 28, 2025
jeff-dude
added
ready-for-final-review
and removed
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the solana phoenix trades integration to dex.trades