Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floki bot spell #7650

Closed
wants to merge 14 commits into from
Closed

Floki bot spell #7650

wants to merge 14 commits into from

Conversation

DavidbigC
Copy link

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]

quick links for more information:

@github-actions github-actions bot marked this pull request as draft February 13, 2025 15:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Feb 13, 2025
@DavidbigC
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 13, 2025
@github-actions
@DavidbigC has signed the CLA in #7650
e79de60
@DavidbigC DavidbigC marked this pull request as ready for review February 13, 2025 16:39
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 13, 2025
Hosuke
Hosuke requested changes Feb 14, 2025
View reviewed changes
Hosuke
Hosuke reviewed Feb 14, 2025
View reviewed changes
dbt_subprojects/solana/models/_sector/dex/bot_trades/solana/_schema.yml
- user

- name: floki_solana_bot_trades
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output seems legit:
https://dune.com/queries/4722905

DavidbigC
DavidbigC commented Feb 14, 2025
View reviewed changes
Copy link
Author

@DavidbigC DavidbigC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip and pipfile.lock back the public version

@DavidbigC DavidbigC requested a review from Hosuke February 14, 2025 13:47
@github-actions github-actions bot added the dbt: dex covers the DEX dbt subproject label Feb 14, 2025
@github-actions github-actions bot removed the dbt: dex covers the DEX dbt subproject label Feb 14, 2025
Hosuke
Hosuke approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @DavidbigC

Sample floki_solana_bot_trades

cc. @whalehunting

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Feb 17, 2025
@jeff-dude jeff-dude marked this pull request as draft February 28, 2025 15:37
@github-actions github-actions bot added the WIP work in progress label Feb 28, 2025
@DavidbigC DavidbigC closed this Mar 27, 2025
@DavidbigC DavidbigC deleted the floki-bot-spell branch March 27, 2025 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

Assignees
No one assigned
Labels
dbt: solana covers the Solana dbt subproject WIP work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidbigC @Hosuke @jeff-dude