Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(banana-gun): add support for USDC fee payment trades #7636

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

whalehunting
Copy link
Contributor

Adds support for trades with USDC payments for Banana Gun dex trading bot on Solana

@github-actions github-actions bot marked this pull request as draft February 9, 2025 18:33
@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Feb 9, 2025
@whalehunting whalehunting marked this pull request as ready for review February 9, 2025 18:34
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 9, 2025
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @whalehunting

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Feb 26, 2025
@jeff-dude jeff-dude self-assigned this Feb 26, 2025
@jeff-dude
Copy link
Member

thanks for review. i'm in contact with whalehunter, and we're looking to plan out how to best refactor solana bot trades. marking as blocked until we find solution.

@jeff-dude jeff-dude marked this pull request as draft February 28, 2025 15:36
@github-actions github-actions bot added the WIP work in progress label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: solana covers the Solana dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants