Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error when providing an unexpected object that doesn't override toString() in a command expr #231

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

dsherret
Copy link
Owner

@dsherret dsherret commented Jan 28, 2024

Previously this would just become [object Object].

const obj1 = {};
assertThrows(
  () => $`echo ${obj1}`,
  Error,
  "Failed resolving expression in command. Provided object does not override `toString()`.",
);

@dsherret dsherret merged commit 7640372 into main Jan 28, 2024
4 checks passed
@dsherret dsherret deleted the feat_error_toString branch January 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant