Error if providing an unsupported redirect.

dsherret · Jan 28, 2024 · 3fbd36e · 3fbd36e
1 parent 8ae893b
commit 3fbd36e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/mod.test.ts b/mod.test.ts
@@ -1149,6 +1149,14 @@ Deno.test("output redirects", async () => {
       assertEquals(result.code, 1);
       assert(result.stderr.startsWith("failed opening file for redirect"));
     }
+
+    {
+      assertThrows(
+        () => $`echo 1 > ${new TextEncoder()}`,
+        Error,
+        "Failed resolving expression in command. Unsupported object provided to output redirect.",
+      );
+    }
   });
 });
 
@@ -1158,6 +1166,13 @@ Deno.test("input redirects", async () => {
     const text = await $`cat - < test.txt`.text();
     assertEquals(text, "Hi!");
   });
+  {
+    assertThrows(
+      () => $`cat - < ${new TextEncoder()} && echo ${"test"}`,
+      Error,
+      "Failed resolving expression 1/2 in command. Unsupported object provided to input redirect.",
+    );
+  }
 });
 
 Deno.test("input redirects with readable", async () => {

diff --git a/src/command.ts b/src/command.ts
@@ -1277,8 +1277,10 @@ function templateInner(
                 },
               });
             });
-          } else {
+          } else if (typeof expr === "string" || expr instanceof PathRef) {
             text += templateLiteralExprToString(expr, escape);
+          } else {
+            throw new Error("Unsupported object provided to input redirect.");
           }
         } else if (inputOrOutputRedirect === ">") {
           if (expr instanceof WritableStream) {
@@ -1294,16 +1296,19 @@ function templateInner(
               }
               return stream;
             });
-          } else {
+          } else if (typeof expr === "string" || expr instanceof PathRef) {
             text += templateLiteralExprToString(expr, escape);
+          } else {
+            throw new Error("Unsupported object provided to output redirect.");
           }
         } else {
           text += templateLiteralExprToString(expr, escape);
         }
       } catch (err) {
-        throw new Error(`Failed resolving expression ${i + 1}/${exprs.length}.`, {
-          cause: err,
-        });
+        const startMessage = exprs.length === 1
+          ? "Failed resolving expression in command."
+          : `Failed resolving expression ${i + 1}/${exprs.length} in command.`;
+        throw new Error(`${startMessage} ${err?.message ?? err}`);
       }
     }
   }