Skip to content

Commit

Permalink
Remove redirection into command. There are some design questions arou…
Browse files Browse the repository at this point in the history
…nd how this should work because it should probably get the current pipes of where it gets injected into the shell and then there's also the question of if it should get the current env.
  • Loading branch information
dsherret committed Jan 28, 2024
1 parent 4a422da commit 076af49
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
8 changes: 0 additions & 8 deletions mod.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1229,14 +1229,6 @@ Deno.test("output redirect with writable", async () => {
}
});

Deno.test("input redirection to command", async () => {
{
const echos = $`echo 1 && echo 2`;
const text = await $`cat - < ${echos}`.text();
assertEquals(text, "1\n2");
}
});

Deno.test("shebang support", async (t) => {
await withTempDir(async (dir) => {
const steps: Promise<boolean>[] = [];
Expand Down
4 changes: 0 additions & 4 deletions src/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@ export class CommandBuilder implements PromiseLike<CommandResult> {
return builder;
}

[symbols.readable](): ReadableStream<Uint8Array> {
return this.stdout("piped").spawn().stdout();
}

then<TResult1 = CommandResult, TResult2 = never>(
onfulfilled?: ((value: CommandResult) => TResult1 | PromiseLike<TResult1>) | null | undefined,
onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null | undefined,
Expand Down

0 comments on commit 076af49

Please sign in to comment.