FEAT: add open api schema extension #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreckonerr
commented
Feb 20, 2025
| # }, | ||
| # favorite_color: { | ||
| # type: "string", | ||
| # minLength: 1, |
There was a problem hiding this comment.
Hmm, this seems to be not necessary for "filled" enums, will add more tests for cases like this and adjust the implementation
There was a problem hiding this comment.
We should also add an additional null enum along with the nullable: true flag for optional enums.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the JSON schema compiler logic by extracting it into a base class, enabling the new OpenAPI schema extension to reuse and extend its functionality.
In the process of migrating our Rails request tests to rswag, I converted our Dry Schemas directly into OpenAPI schema. Since Dry Schema already had JSON Schema extension support, this approach was straightforward to implement.
Note: Although the contribution guidelines suggest linking to a reported issue, I wasn't able to create an issue for this functionality without using a bug report template.