[docsite] Break up first Maybe() example into three lines #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On smaller (laptop-sized) screens, these lines break in a way that's hard to read. Since this is likely the very first time readers are seeing dry-monads in action, we should take particular attention to showing that the code is _more_ readable and elegant than the procedural option shown before it
cllns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On medium (laptop-sized) screens, these lines break in a way that's hard to read. Since this is likely the very first time readers are seeing dry-monads in action, we should take particular attention to showing that the code is more readable and elegant than the procedural option shown before it.
The reason this happens is that the only space in the line is after the
id:.Before this PR:
After this PR:
On tiny (phone) screens, this long line of
.maybe(&:method)s still breaks in a weird way. We could 'fix' that by putting each.maybe()on its own line and I'd be happy to do that, but we should do that uniformly across the docsite (all of the dry-rb docsites, ideally 😬 ) rather than just this one.