Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterables Feature Request - Expanded #302

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dirtyonekanobi
Copy link

This pr expounds on terlmen0's PR #218 (with permission) - but makes the following changes:

  • Instead of implementing a separate model for Iterables/Itervalues, we take an approach similar to the way Networks handle adjacencies.
  • Parent/children of iterables are in the same model
  • introduced a 'value' to the Iterables model
  • Iterables are now a Resource and can be queried using attributes
  • adjusted the get_next_value() iterable method to account for children

Please feel free to suggest any changes. Thank you!

@jathanism
Copy link
Contributor

@dirtyonekanobi Just taking a look at this now. Thank you so much for contributing.

@jathanism
Copy link
Contributor

Hey let's keep this moving! Let's get this updated for the latest release and get the tests working.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Daryn Johnson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants