-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support for insert id for postgres #17
adds support for insert id for postgres #17
Conversation
Circle Ci check is failing the tests. I had the same issue when I first ran the tests. It gave me an error |
@@ -21,7 +21,7 @@ | |||
/** | |||
* Class EmptyDoctrineMysqlDriver. | |||
*/ | |||
final class EmptyDoctrineMysqlDriver extends AbstractMySQLDriver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the meaning of that removed line
Tests are not passing
I'm fixing all these problems and I will update the PR and ping you. Thanks! |
|
||
abstract class AbstractDriver | ||
{ | ||
abstract public function query(string $sql, array $parameters): PromiseInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is already defined for implementation in the Driver interface. Because this class is abstract, you don't have to implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all drivers have to extend this AbstractDriver
, then the interface can be implemented directly in this abstract class and not in the specific classes (the contract is implicit when you extend)
@developernaren I've completed your PR here - #19 |
Adds support for insert id in postgres
Changes made
composer.lock
does not have phpunit so did a composer install to update the composer