Feature/added shortcuts #11
Conversation
src/Connection.php
Outdated
| * connection->findOneById('table', ['id' => 1]); | ||
| * | ||
| * @param string $table | ||
| * @param array $id |
There was a problem hiding this comment.
I'd name it $where or $conditions since it doesn't necessarily have to be primary key (same for delete and update) and name the method simply findOneBy.
src/Connection.php
Outdated
| * @param string $table | ||
| * @param array $id | ||
| * | ||
| * @return array|null |
There was a problem hiding this comment.
@return PromiseInterface<mixed[]|null>
src/Connection.php
Outdated
| /** | ||
| * Find by. | ||
| * | ||
| * connection->findOneById('table', ['id' => 1]); |
There was a problem hiding this comment.
copy paste error - this is the findBy method
| ->values(array_combine( | ||
| array_keys($values), | ||
| array_fill(0, count($values), '?') | ||
| )) | ||
| ->setParameters(array_values($values)); |
There was a problem hiding this comment.
Personally I prefer my simple foreach over these array shenanigans but whatever.
src/Connection.php
Outdated
| string $table, | ||
| array $id, | ||
| array $values | ||
| ) { |
| * @param array $id | ||
| * @param array $values | ||
| * | ||
| * @return PromiseInterface |
There was a problem hiding this comment.
Promise of...? @return PromiseInterface<...>
| @@ -20,7 +20,7 @@ | |||
| use Exception; | |||
|
|
|||
| /** | |||
| * Class MockedDriver | |||
| * Class MockedDriver. | |||
There was a problem hiding this comment.
Comments like these are totally useless. I highly recommend removing them everywhere.
There was a problem hiding this comment.
Thanks for your recommendation. I like these redundant comments 👍
| * @param Connection $connection | ||
| * | ||
| * @return PromiseInterface |
There was a problem hiding this comment.
@param is redundant since there is typehint, @return should be made non-redundant by adding the type of the resolved value as <...>.
mmoreram
force-pushed
the
feature/added-shortcuts
branch
from
a038338 to
9fe3702
Compare
- findOneBy - findBy - insert - update - upsert - delete
mmoreram
force-pushed
the
feature/added-shortcuts
branch
from
9fe3702 to
24c36e9
Compare
No description provided.