Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(find-replace): use esc to focus on selection #4746

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 28, 2025

close #4550

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 28, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 28, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 33 seconds
commit  6034e23
info  For more information, see full report

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 32.59%. Comparing base (d9b2ec6) to head (6034e23).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ets/src/commands/operations/selection.operation.ts 11.11% 8 Missing ⚠️
.../find-replace/src/services/find-replace.service.ts 0.00% 6 Missing ⚠️
.../src/commands/operations/find-replace.operation.ts 0.00% 5 Missing ⚠️
...e/src/controllers/sheet-find-replace.controller.ts 0.00% 4 Missing ⚠️
...d-replace/src/controllers/find-replace.shortcut.ts 0.00% 3 Missing ⚠️
packages/design/src/components/dialog/Dialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4746   +/-   ##
=======================================
  Coverage   32.58%   32.59%           
=======================================
  Files        2610     2610           
  Lines      136048   136075   +27     
  Branches    30270    30274    +4     
=======================================
+ Hits        44331    44353   +22     
- Misses      91717    91722    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Feb 28, 2025
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 28, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 28, 2025
@zhaolixin7 zhaolixin7 added the qa:untested This PR is ready to be tested label Feb 28, 2025
@univer-bot univer-bot bot removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 28, 2025
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 28, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 28, 2025
@wzhudev wzhudev merged commit f4b30ae into dev Feb 28, 2025
9 checks passed
@wzhudev wzhudev deleted the feat/search-auto-focus branch February 28, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Move focus to matched cell on ESC in the Find-Replace plugin
3 participants