Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): supplement f-workbook f-worksheet f-range facade #4733

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

wpxp123456
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 27, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 requested a review from jikkai February 27, 2025 03:08
Copy link

github-actions bot commented Feb 27, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  058c3b1
info  For more information, see full report

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 245 lines in your changes missing coverage. Please review.

Project coverage is 32.58%. Comparing base (5f6130a) to head (058c3b1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-range.ts 0.00% 163 Missing ⚠️
...sheets/src/commands/commands/append-row.command.ts 0.00% 25 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 21 Missing ⚠️
packages/sheets-numfmt/src/facade/f-range.ts 0.00% 13 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 11 Missing ⚠️
packages/sheets/src/facade/f-workbook.ts 0.00% 8 Missing ⚠️
packages/sheets/src/facade/utils.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4733      +/-   ##
==========================================
- Coverage   32.64%   32.58%   -0.06%     
==========================================
  Files        2608     2609       +1     
  Lines      135751   135988     +237     
  Branches    30197    30245      +48     
==========================================
  Hits        44314    44314              
- Misses      91437    91674     +237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpxp123456 wpxp123456 requested a review from Dushusir February 27, 2025 03:21
@wpxp123456 wpxp123456 requested a review from Dushusir February 27, 2025 03:32
@wpxp123456 wpxp123456 merged commit edddb71 into dev Feb 27, 2025
9 checks passed
@wpxp123456 wpxp123456 deleted the pxp/02241923 branch February 27, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants