Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add cell image facade & remove rich-text cell-image #4729

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Feb 26, 2025

close #4612

  1. Adding facade api for add cell image.
  2. Remove rich-text features on cell-image (no longer support mixture layout of images and texts).

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 26, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 26, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 34 seconds
commit  f850323
info  For more information, see full report

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 8.04598% with 80 lines in your changes missing coverage. Please review.

Project coverage is 32.58%. Comparing base (e4a5639) to head (f850323).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...src/controllers/sheet-drawing-update.controller.ts 0.00% 25 Missing ⚠️
...kages/sheets-hyper-link-ui/src/controllers/menu.ts 0.00% 22 Missing ⚠️
...-ui/src/controllers/sheet-cell-image.controller.ts 0.00% 11 Missing ⚠️
packages/sheets-drawing-ui/src/facade/f-range.ts 0.00% 11 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 5 Missing ⚠️
packages/sheets-zen-editor/src/views/menu.ts 0.00% 3 Missing ⚠️
packages/sheets-hyper-link-ui/src/utils/index.ts 0.00% 2 Missing ⚠️
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4729      +/-   ##
==========================================
- Coverage   32.58%   32.58%   -0.01%     
==========================================
  Files        2609     2610       +1     
  Lines      135999   136053      +54     
  Branches    30250    30271      +21     
==========================================
+ Hits        44314    44331      +17     
- Misses      91685    91722      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit f0b2d48 into dev Feb 27, 2025
9 checks passed
@weird94 weird94 deleted the feat/cell-image-facade branch February 27, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants