Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashline drawing incorrect when adjust col width #4719

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 25, 2025

close https://github.com/dream-num/univer-pro/issues/4048

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 25, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  0b40a9a
info  For more information, see full report

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.61%. Comparing base (5b95c59) to head (0b40a9a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/basics/draw.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4719   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files        2605     2605           
  Lines      135848   135848           
  Branches    30228    30228           
=======================================
  Hits        44306    44306           
  Misses      91542    91542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Feb 25, 2025
@lumixraku lumixraku merged commit d163f2e into dev Feb 25, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/dashed-borderline branch February 25, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants