Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll bar hover style #4708

Merged
merged 5 commits into from
Feb 26, 2025
Merged

feat: scroll bar hover style #4708

merged 5 commits into from
Feb 26, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 22, 2025

close https://github.com/dream-num/univer-pro/issues/4033

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 22, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as draft February 22, 2025 14:08
@lumixraku lumixraku self-assigned this Feb 22, 2025
Copy link

github-actions bot commented Feb 22, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  2b3e37f
info  For more information, see full report

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 206 lines in your changes missing coverage. Please review.

Project coverage is 32.65%. Comparing base (5b95c59) to head (2b3e37f).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/shape/scroll-bar.ts 0.00% 205 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4708      +/-   ##
==========================================
+ Coverage   32.61%   32.65%   +0.03%     
==========================================
  Files        2605     2606       +1     
  Lines      135848   135710     -138     
  Branches    30228    30179      -49     
==========================================
+ Hits        44306    44314       +8     
+ Misses      91542    91396     -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku changed the title fix: test1 feat: scroll bar hover style Feb 24, 2025
@lumixraku lumixraku force-pushed the fix/scrollbar-size branch 5 times, most recently from d56e29d to aff6d38 Compare February 25, 2025 09:27
@lumixraku lumixraku marked this pull request as ready for review February 25, 2025 09:27
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 26, 2025
@lumixraku lumixraku merged commit 04af678 into dev Feb 26, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/scrollbar-size branch February 26, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants