Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): avoid auto height too many rows #4700

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

VicKun4937
Copy link
Contributor

  • fix select a column set font size cause performance

Copy link

github-actions bot commented Feb 21, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  351f96e
info  For more information, see full report

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (95410d0) to head (351f96e).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...heets-ui/src/controllers/auto-height.controller.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4700      +/-   ##
==========================================
- Coverage   32.66%   32.66%   -0.01%     
==========================================
  Files        2606     2606              
  Lines      135685   135695      +10     
  Branches    30208    30211       +3     
==========================================
  Hits        44319    44319              
- Misses      91366    91376      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit 5d036b7 into dev Feb 21, 2025
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-auto-height-performance branch February 21, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants