Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add multi units playground #4666

Merged
merged 6 commits into from
Feb 24, 2025
Merged

chore: add multi units playground #4666

merged 6 commits into from
Feb 24, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 18, 2025

close https://github.com/dream-num/univer-pro/issues/4021

  • We need to clear these caches when univer.dispose(), which has been checked
    • FormulaLexerNodeCache // DONE
    • FormulaSequenceNodeCache // DONE
    • FORMULA_REF_TO_ARRAY_CACHE // DONE
    • FORMULA_AST_CACHE // DONE
    • numberFormatTypeCache // DONE
    • stringToNumberPatternCache // DONE
    • referenceToRangeCache // DONE
    • ErrorValueObjectCache // DONE
    • StringValueObjectCache // DONE
    • CELL_INVERTED_INDEX_CACHE // DONE
  • check dispose in formula engine
  • fix setting CalculationMode before Ready lifecycle

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 18, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 18, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 32 seconds
commit  5bd7ddb
info  For more information, see full report

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 32.65%. Comparing base (3815948) to head (5bd7ddb).
Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
...-formula/src/services/calculate-formula.service.ts 0.00% 8 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 5 Missing ⚠️
...formula/src/services/dependency-manager.service.ts 0.00% 3 Missing ⚠️
...rc/services/feature-calculation-manager.service.ts 0.00% 2 Missing ⚠️
...la/src/services/global-computing-status.service.ts 0.00% 2 Missing ⚠️
...engine-formula/src/services/super-table.service.ts 0.00% 2 Missing ⚠️
...es/engine-formula/src/services/function.service.ts 0.00% 1 Missing ⚠️
...mula/src/services/other-formula-manager.service.ts 0.00% 1 Missing ⚠️
.../sheets-formula-ui/src/sheets-formula-ui.plugin.ts 0.00% 1 Missing ⚠️
packages/sheets-formula/src/facade/f-formula.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4666      +/-   ##
==========================================
- Coverage   32.67%   32.65%   -0.02%     
==========================================
  Files        2605     2605              
  Lines      135635   135658      +23     
  Branches    30189    30188       -1     
==========================================
- Hits        44317    44302      -15     
- Misses      91318    91356      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review February 20, 2025 07:43
@wzhudev wzhudev merged commit 3f5b60c into dev Feb 24, 2025
9 checks passed
@wzhudev wzhudev deleted the fix/multi-units branch February 24, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants