Release version 4.0.4, update changelog #942
Conversation
|
The CI failures seem to be unrelated to this PR. |
|
Apparently it's an issue with concurrent-ruby: https://stackoverflow.com/questions/79360526 |
There was a problem hiding this comment.
I haven't time to look through it yet, sorry. That's great that you, @seanlinsley, did that already.
| @@ -1,3 +1,3 @@ | |||
| module Draper | |||
| VERSION = '4.0.2' | |||
| VERSION = '4.1.0-pre' | |||
There was a problem hiding this comment.
I just incremented it to 4.1 based on this comment: #921 (comment). I haven't looked at the changes on the master branch too closely. Thoughts @y-yagi?
There was a problem hiding this comment.
At first, I didn't notice the PR to be for the master branch, sorry. I was thinking of it still in the context of my faulty cherry-picking.
I'm not sure what version describes our master branch best for now. For me, pre-release of v4.1 sounds good, while @y-yagi considers some commits to be of v5.0.
There was a problem hiding this comment.
BTW, it's best not to delete your comments because that makes it more difficult to tell what someone was responding to. If you feel the need to show that a comment is no longer valid, you can strike it out with markdown
| @@ -1,3 +1,3 @@ | |||
| module Draper | |||
| VERSION = '4.0.2' | |||
| VERSION = '4.1.0-pre' | |||
There was a problem hiding this comment.
I just incremented it to 4.1 based on this comment: #921 (comment). I haven't looked at the changes on the master branch too closely. Thoughts @y-yagi?
I'm sorry to notice it later. I've checked it already and removed my unrelated comment, but you are very fast to reply. |
|
Okay,I've published version 4.0.4 to rubygems. I'll go ahead and merge this so the changelog is up to date. We can fix the CI failure and decide on 4.1 vs 5.0 versioning after the fact. |
Fixes #941 (comment)
I've pushed the updated version to the
v4.0.4git tag. You can see the diff here: v4.0.3...v4.0.4I'll hold off on publishing it to rubygems until this PR is approved.