Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add ability to reinit incoming migration object #4756

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BorysTheDev
Copy link
Contributor

Made outgoing and incoming migration objects' lifetimes more similar

@BorysTheDev BorysTheDev marked this pull request as ready for review March 12, 2025 12:04
@BorysTheDev BorysTheDev force-pushed the reuse_incoming_migration_object branch from 5d606b6 to 3eb3777 Compare March 12, 2025 12:36
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave Adi to follow up with the rest of the changes. Small questions for me

@BorysTheDev BorysTheDev force-pushed the reuse_incoming_migration_object branch from 3eb3777 to 6510136 Compare March 27, 2025 08:59
@BorysTheDev BorysTheDev requested a review from adiholden March 27, 2025 09:00
@BorysTheDev BorysTheDev force-pushed the reuse_incoming_migration_object branch from 6510136 to 1cfea80 Compare March 27, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants