dotnet CLI: "Collection initialization can be simplified"

[MiYanni]

Summary

This is running the automatic cleanup for IDE0028 and IDE0300, "Collection initialization can be simplified", in the dotnet and Cli.Utils projects. Any other formatting changes are a result of that analyzer. No manual code changes were made. Manual adjustments to style were made after PR feedback.

Note

The tool crashes the first time trying to run it on the dotnet project. To get the tool to run properly, run it once, let it crash, hit the Enable button on the gold banner that appears, and run it again.

Tool in VS

IDE0028

IDE0300

[Copilot]

Pull Request Overview

This PR applies automatic cleanup changes from the IDE0028 analyzer to simplify collection initializations across several projects within the dotnet CLI and Cli.Utils codebases. The key changes include replacing verbose collection initializations with simplified syntax, updating list and dictionary initializations, and modifying array initializations.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
src/Cli/dotnet/Commands/Test/IPC/Serializers/HandshakeMessageSerializer.cs	Replaces dictionary initialization with an invalid literal form.
src/Cli/dotnet/CliTransaction.cs	Changes list initializations for RollbackActions and CleanupActions to an invalid literal form.
src/Cli/dotnet/Commands/MSBuild/MSBuildLogger.cs	Updates dictionary and measurement initializations with invalid literal forms.
src/Cli/dotnet/Commands/Package/Add/Program.cs	Converts list initialization from multiple Add calls to a literal form that is not valid.
src/Cli/dotnet/CommandFactory/CommandSpec.cs	Uses an incorrect literal for dictionary initialization in the EnvironmentVariables property.
src/Cli/Microsoft.DotNet.Cli.Utils/DotDefaultPathCorrector.cs	Changes the call to Split() to use an invalid array literal syntax.
src/Cli/dotnet/Commands/Run/RunCommand.cs	Modifies list initialization for restore arguments with an invalid literal form.
src/Cli/dotnet/CommandFactory/CommandResolution/ProjectToolsCommandResolver.cs	Changes list initialization for allowed command extensions and tool frameworks to an invalid literal form.
src/Cli/dotnet/Commands/Restore/RestoringCommand.cs	Replaces a HashSet initialization with an invalid literal.
src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs	Updates dictionary initialization for saved environment variables to use an invalid literal.
src/Cli/dotnet/CommandFactory/CommandResolution/CompositeCommandResolver.cs	Converts list initialization to an invalid literal form.
src/Cli/dotnet/CommandFactory/CommandResolution/LockFileTargetExtensions.cs	Changes HashSet initialization to an invalid literal form.
src/Cli/dotnet/Commands/New/MSBuildEvaluation/MSBuildEvaluator.cs	Updates dictionary initialization for evaluated target framework projects using an invalid literal.
src/Cli/Microsoft.DotNet.Cli.Utils/StreamForwarder.cs	Modifies static array initialization using an incorrect literal syntax.
src/Cli/Microsoft.DotNet.Cli.Utils/EnvironmentProvider.cs	Replaces char array initializations with invalid literal syntax.
src/Cli/dotnet/Commands/Restore/RestoreCommandParser.cs	Changes list initialization for convertedRids to an invalid literal form.
src/Cli/Microsoft.DotNet.Cli.Utils/TypoCorrection.cs	Updates jagged array initialization of rows using an incorrect literal.
src/Cli/dotnet/CommandResolution/DepsJsonCommandResolver.cs	Changes list initialization for muxerArgs to an invalid literal form.

Comments suppressed due to low confidence (4)

src/Cli/dotnet/Commands/Package/Add/Program.cs:70

• The new list initialization using square bracket literal is invalid in C#. Use the collection initializer with curly braces, e.g., 'new List { ... }'.

var args = new List<string>

src/Cli/dotnet/Commands/Run/RunCommand.cs:279

• The use of square brackets in list initialization is incorrect; use the standard collection initializer syntax with curly braces.

List<string> args = new List<string> =

src/Cli/dotnet/CommandFactory/CommandResolution/ProjectToolsCommandResolver.cs:30

• Initializing a List with [] is not valid in C#. Replace it with 'new List()' or a proper collection initializer using curly braces.

_allowedCommandExtensions = [];

src/Cli/dotnet/CommandResolution/DepsJsonCommandResolver.cs:191

• The updated initialization of muxerArgs using square brackets is not valid in C#. Use 'new List { "exec" }' for a proper collection initializer.

var muxerArgs = new List<string>

[edvilme]

Like the consistency, thanks for putting the effort into this. Left a couple of nit comments. I know this refactoring is an ongoing process, and that these changes are mostly the result of tooling, so leaving my approval :)

[MiYanni]

Reran the tools again and adjusted all the changes to match the style based on the PR suggestions. It seems that running the tools once don't actually work on all problematic instances, which is bizarre.